Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

*: reduce unnecessary error stack trace #610

Merged
merged 3 commits into from
Nov 25, 2020
Merged

*: reduce unnecessary error stack trace #610

merged 3 commits into from
Nov 25, 2020

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Reduce unnecessary stack trace in warning logs.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

@overvenus
*: reduce unnecessary error stack trace
e0b203c 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
docker: update docker-compose.yaml
2d5d486 
Signed-off-by: Neil Shen <overvenus@gmail.com>
kennytm
kennytm reviewed Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

pkg/logutil/logging.go Outdated Show resolved Hide resolved
@overvenus @kennytm
Update pkg/logutil/logging.go
7e08de9 
Co-authored-by: kennytm <kennytm@gmail.com>
@kennytm
Copy link
Collaborator

kennytm commented Nov 24, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Nov 24, 2020
@glorv
Copy link
Collaborator

glorv commented Nov 24, 2020

/run-all-tests

@glorv
Copy link
Collaborator

glorv commented Nov 24, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGTM1 label Nov 24, 2020
@ti-srebot ti-srebot added the status/LGT2 LGTM2 label Nov 24, 2020
@overvenus
Copy link
Member Author

/run-integration-tests

@kennytm kennytm merged commit 8454a8c into pingcap:master Nov 25, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 failed

@overvenus overvenus added this to the v4.0.9 milestone Nov 26, 2020
lichunzhu added a commit to lichunzhu/br that referenced this pull request Nov 26, 2020
@lichunzhu
cherry-pick pingcap#610
ab6b5b8
overvenus pushed a commit that referenced this pull request Nov 27, 2020
@lichunzhu @3pointer
@tangwz @YuJuncen @kennytm
cherry-pick important features to release-4.0 branch (#622)
1d3fb98 
* cherry-pick #610
* cherry-pick #605
* fix: backup will skip empty databases. (#560)

Co-authored-by: 3pointer <luancheng@pingcap.com>
Co-authored-by: tangwz <tangwz.com@gmail.com>
Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: kennytm <kennytm@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 status/LGT2 LGTM2
Projects
None yet
Milestone
v4.0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@overvenus @kennytm @glorv @ti-srebot